Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(osmomath): BigDec Clone() and MulMut methods #3678

Merged
merged 1 commit into from
Dec 9, 2022
Merged

feat(osmomath): BigDec Clone() and MulMut methods #3678

merged 1 commit into from
Dec 9, 2022

Conversation

p0mvn
Copy link
Member

@p0mvn p0mvn commented Dec 9, 2022

Closes: #XXX

What is the purpose of the change

Context: #3676 (comment)

We would like to have a mutative and nonmutatuve Power function. This requires implementing a mutative multiplication function first. This PR does so by introducing Clone, MulMut functions defined on BigDec and Mul utilizing the new functions.

Testing and Verifying

  • covered by existing Mut tests.
  • added tests for Clone
  • added test to check MulMut mutates and Mut does not

Documentation and Release Note

  • Does this pull request introduce a new feature or user-facing behavior changes? no
  • Is a relevant changelog entry added to the Unreleased section in CHANGELOG.md? yes
  • How is the feature or change documented? not applicable

@p0mvn p0mvn mentioned this pull request Dec 9, 2022
Merged
@p0mvn p0mvn added V:state/compatible/backport State machine compatible PR, should be backported A:backport/v13.x backport patches to v13.x branch labels Dec 9, 2022
@p0mvn p0mvn requested a review from ValarDragon December 9, 2022 16:41
@p0mvn p0mvn marked this pull request as ready for review December 9, 2022 17:01
ValarDragon
ValarDragon approved these changes Dec 9, 2022
View reviewed changes
Copy link
Member

@ValarDragon ValarDragon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@ValarDragon ValarDragon merged commit 1846a99 into main Dec 9, 2022
@ValarDragon ValarDragon deleted the roman/osmomath-mulmut branch December 9, 2022 17:49
@mergify mergify bot mentioned this pull request Dec 9, 2022
Merged
mergify bot pushed a commit that referenced this pull request Dec 9, 2022
@p0mvn @mergify
feat(osmomath): BigDec Clone() and MulMut methods (#3678)
8d63675 
(cherry picked from commit 1846a99)

# Conflicts:
#	CHANGELOG.md
p0mvn added a commit that referenced this pull request Dec 10, 2022
@p0mvn
feat(osmomath): BigDec Clone() and MulMut methods (backport #3678)
2ec2abd
p0mvn added a commit that referenced this pull request Dec 10, 2022
@mergify @p0mvn
feat(osmomath): BigDec Clone() and MulMut methods (backport #3678) (#…
8e77d98 
…3679)

Co-authored-by: Roman <[email protected]>
@p0mvn p0mvn mentioned this pull request Dec 16, 2022
Closed
@github-actions github-actions bot mentioned this pull request May 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ValarDragon ValarDragon ValarDragon approved these changes

Assignees
No one assigned
Labels
A:backport/v13.x backport patches to v13.x branch V:state/compatible/backport State machine compatible PR, should be backported
Projects
Osmosis Chain Development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@p0mvn @ValarDragon